Make non-null fields required

[cdman]

No description provided.

[cdman]

Hello everyone,

I'm not sure that this is the right solution, however I'm pretty sure that this is a "real" problem. To sum it up, I would expect the following code to raise an IntegrityError, just as it does if you replace PickledObjectField with an IntegerField for example (because it doesn't have null=True):

class MinimalTestingModel(models.Model):
    field = PickledObjectField()

MinimalTestingModel.objects.create()

Currently it silently stores an unicode empty string (u'') in such cases.

[coveralls]

Coverage increased (+4.6%) to 96.629% when pulling 6313b66 on gpanther:warn-on-unset-value into dfa4f6e on gintas:master.

[charettes]

While backward incompatible I feel like this is an issue that should be fixed.

[charettes]

I think the appropriate solution might be to set PickledObjectField.empty_strings_allowed = False.

https://github.com/django/django/blob/63de263e030d2a3fd7ff62ae9bc809a5572d351a/django/db/models/fields/__init__.py#L807

[cdman]

@charettes - thanks for the quick reaction. I updated the code to use the proposed solution (the one with empty_strings_allowed = False).

All the best.

[charettes]

@cdman looking good! Do you think you could rebase on top of master and mention this change in the README.rst for the 1.1.0 version.

[cdman]

@charettes - done. I'm a little un-easy about releasing such a breaking change in a minor version bump but it's your call 😄.

[charettes]

@cdman I rebased your branch for 2.0 which I plan to release today.