-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated DEFAULT_PROTOCOL to 3. #50
Conversation
Hey @carltongibson 👋 Looks like it only breaks the Python 2 build which is expected. Given tests already pass on Python 2 simply removing tested support (tox.ini, .travis.yml, setup.py) and adding a section for in the README.rst release notes under a new 3.0 section would do. Removal of Python support code can be done in a following PR. |
40352c1
to
a52948e
Compare
Hi @charettes 👋 I dropped PY2 in a separate commit, if you're happy to take that. If you're happy with these I can rebase and drop 1.11 too whilst I'm here. |
@@ -26,8 +26,7 @@ | |||
'License :: OSI Approved :: MIT License', | |||
'Operating System :: OS Independent', | |||
'Programming Language :: Python', | |||
'Programming Language :: Python :: 2', | |||
'Programming Language :: Python :: 2.7', | |||
'Programming Language :: Python :: 3 :: Only', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't know about that :: Only
classifier, TIL!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Angry people tell me about these things when I forget to use them... 😀
Totally open to that if you're up to it! I can take care of releasing 3.0 afterwards. It looks like the |
OK, I'll add it here. 10 mins. |
> Protocol version 3 was added in Python 3.0. It has explicit support for bytes objects and cannot be unpickled by Python 2.x. This was the default protocol in Python 3.0–3.7.
Looks like Travis is taking a ☕ break. |
I don't blame it. 😀 I'll check back on this later. Hopefully the lint builds work with |
We could run it against 3.7 (or even 3.8) if the django-picklefield/.travis.yml Lines 17 to 18 in 44dfeb9
|
It seems to be OK now. https://travis-ci.org/github/gintas/django-picklefield/builds/695030386 |
Perfect thanks! |
Not sure it dropping PY2 is on the cards now that it's EOL but, if so I think it would be fair to bump the default protocol version.
WIP because they'll be lots that breaks on tox/travis. I will check back on that later.