PHPUnit 5 compatibility #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorgiosironi
force-pushed
the
phpunit_5_compatibility
branch
from
0b5547b
to
743e42d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As signaled in #351, there are incompatibilities between the current version of PHPUnit_Selenium and PHPUnit 5.
It is a losing proposition to still support Selenium 1 API (
SeleniumTestCase), as it redefines methods that have even changed signatures. It has not been maintained for years.So to support PHPUnit 5.x there will be a new major version of this project,
2.x. The old1.xbranch will remain available but not updated anymore.2.xwill contain:Selenium2TestCaseand work with PHPUnit 4.x or 5.x, with correspondent PHP versions.
1.xwill contain:SeleniumTestCaseSelenium2TestCasebut will only work with PHPUnit 4.x, with correspondent PHP versions. In general, it will not be updated anymore.
This PR will remain open for comment and feedback until December 19th, 2015.