Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add homology_dimensions to diagrams transformers #107

Open
nphilou opened this issue Dec 10, 2019 · 1 comment
Open

Add homology_dimensions to diagrams transformers #107

nphilou opened this issue Dec 10, 2019 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects

Comments

@nphilou
Copy link
Contributor

nphilou commented Dec 10, 2019

Description

In the current implementation of diagrams.Scaler, Amplitude and PersistenceEntropy, homology dimensions that don't appear in fit will not be considered in transform.

It might lead to some unexpected results.

Possible improvements

  • Documentation
  • Add homology_dimensions parameter (as done for Filtering) to transformers that might ignore some dimensions in transform

PS: Maybe I'm the only one who thinks that it's not clear enough

@ulupo ulupo added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 1, 2020
@ulupo ulupo added this to To do in v0.1.4 via automation Jan 1, 2020
@ulupo ulupo self-assigned this Jan 1, 2020
@ulupo ulupo added this to the 0.1.4 milestone Jan 1, 2020
@ulupo
Copy link
Collaborator

ulupo commented Feb 2, 2022

This is still relevant, and should be bumped.

@ulupo ulupo removed this from the 0.1.4 milestone Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
No open projects
v0.1.4
  
To do
Development

No branches or pull requests

2 participants