Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_filter utility function has bad behaviour when death values are negative #91

Closed
ulupo opened this issue Nov 19, 2019 · 0 comments · Fixed by #436
Closed

_filter utility function has bad behaviour when death values are negative #91

ulupo opened this issue Nov 19, 2019 · 0 comments · Fixed by #436
Assignees
@gtauzin @ulupo
Labels
bug Something isn't working
Projects
v0.1.4 v0.3
Milestone
0.2.0

Comments

@ulupo
Copy link
Collaborator

ulupo commented Nov 19, 2019 •
edited

https://github.com/giotto-ai/giotto-learn/blob/647dd86b91176f87a5ee69ae64b803d1e02f9630/giotto/diagrams/_utils.py#L56

The above line in the definition of _filter would presumably yield bad behaviour for filtrations which admit negative parameters, if there are non-positive death values. This in turn would badly affect the behaviour of the Filtering class in future releases.
@ulupo ulupo added the bug Something isn't working label Nov 19, 2019
@ulupo ulupo added this to the 0.1.4 milestone Jan 1, 2020
@ulupo ulupo added this to To do in v0.1.4 via automation Jan 1, 2020
@ulupo ulupo removed this from the 0.1.4 milestone Feb 10, 2020
@ulupo ulupo added this to To do in v0.3 via automation Feb 10, 2020
@ulupo ulupo added this to the 0.2.0 milestone Feb 10, 2020
@ulupo ulupo mentioned this issue Jul 17, 2020
Merged
9 tasks
@ulupo ulupo closed this as completed in #436 Aug 1, 2020
v0.3 automation moved this from To do to Done Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gtauzin gtauzin

@ulupo ulupo

Labels
bug Something isn't working
Projects
v0.3
  
Done
v0.1.4
  
To do
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Remove incorrect assumptions in Filtering ulupo/giotto-tda
2 participants
@gtauzin @ulupo