Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Architectural goals #45

Closed
4 of 5 tasks
nphilou opened this issue Dec 6, 2019 · 1 comment
Closed
4 of 5 tasks

Architectural goals #45

nphilou opened this issue Dec 6, 2019 · 1 comment
Labels
discussion issues that require further discussion enhancement New feature or request

Comments

@nphilou
Copy link
Contributor

nphilou commented Dec 6, 2019

Proposal A
Decorators to convert into DataFrame

Proposal B
array-like transformers (personal preference)

Issues
Should we return np.array or pd.DataFrame with np.array as input ?
See scikit-learn/scikit-learn#5523 (comment)

Comments and links:
SL/DataFrame current support: https://scikit-learn.org/stable/modules/generated/sklearn.compose.ColumnTransformer.html

SL is more likely to (better) support DataFrame in the future: https://scikit-learn.org/dev/roadmap.html
SL sample properties future support: scikit-learn/scikit-learn#4497
SL/Pandas mapping: https://github.com/scikit-learn-contrib/sklearn-pandas (not maintained)

Cesium is not fit_transform compliant: cesium-ml/cesium#243
Prophet don't use np.array at all and isn't sklearn API compliant (but still use fit/transform model). My suggestion would be to have something close to Prophet to allow people using both libs in the same project as smoothly as possible.

Scikit-learn transformers useful links:
https://scikit-learn.org/dev/developers/develop.html
https://github.com/scikit-learn-contrib/project-template/blob/master/skltemplate/_template.py#L136

To be discussed:

@alexbacce alexbacce added discussion issues that require further discussion enhancement New feature or request labels Dec 20, 2019
@nphilou
Copy link
Contributor Author

nphilou commented Jan 6, 2020

  • Refactor causality_tests tests

Modules to make (more) sklearn compatible

  • causality_tests
  • experimental
  • feature_creation
  • models

@nphilou nphilou mentioned this issue Jan 6, 2020
5 tasks
@nphilou nphilou self-assigned this Jan 17, 2020
@nphilou nphilou removed their assignment Nov 19, 2021
@nphilou nphilou closed this as completed Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion issues that require further discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants