Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Candidatures : Corriger les URLs de retour du sélecteur de métiers [GEN-8171] #3804

Merged
merged 1 commit into from
May 2, 2024
Merged

Candidatures : Corriger les URLs de retour du sélecteur de métiers [GEN-8171] #3804

merged 1 commit into from
May 2, 2024

Conversation

francoisfreitag
Copy link
Contributor

@francoisfreitag francoisfreitag commented Mar 19, 2024 •
edited
Loading

No description provided.

@francoisfreitag francoisfreitag self-assigned this Mar 19, 2024
@notion-workspace Notion Workspace
Copy link

☠️ ETQU qui postule, lorsque je suis sur l’étape de sélection des métiers je veux pouvoir revenir aux informations de mon candidat (investigation supportix)

@francoisfreitag francoisfreitag added the pending PR en attente, ne pas intégrer. label Mar 19, 2024
@francoisfreitag francoisfreitag force-pushed the ff/update-jobseeker-info branch 2 times, most recently from 71ea163 to b9cfbeb Compare March 25, 2024 17:07
@notion-workspace Notion Workspace
Copy link

☠️ ETQU qui postule, lorsque je suis sur l’étape de sélection des métiers je veux pouvoir revenir aux informations de mon candidat (investigation supportix)

@francoisfreitag francoisfreitag force-pushed the ff/update-jobseeker-info branch 3 times, most recently from a7c06ff to 17e5115 Compare April 4, 2024 13:06
@francoisfreitag francoisfreitag added the 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC label Apr 4, 2024
@francoisfreitag francoisfreitag added 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC and removed 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC labels Apr 4, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@francoisfreitag francoisfreitag removed the pending PR en attente, ne pas intégrer. label Apr 8, 2024
@francoisfreitag francoisfreitag marked this pull request as ready for review April 8, 2024 08:22
@francoisfreitag francoisfreitag requested a review from a team April 8, 2024 08:22
@francoisfreitag francoisfreitag added 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC and removed 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC labels Apr 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024

🥁 La recette jetable est prête ! 👉 Je veux tester cette PR !

Préciser comment accéder à la fonctionnalité pour le métier :

  1. …

@francoisfreitag
Copy link
Contributor Author

Mis à jour en fonction des retours de recette : https://www.notion.so/plateforme-inclusion/ETQEmployeur-qui-postule-nouveau-pour-1-meme-candidat-quand-je-clique-sur-retour-je-m-attends-r-1575b03342594346abef67fd7d467782

@francoisfreitag francoisfreitag force-pushed the ff/update-jobseeker-info branch 3 times, most recently from 7e883ae to d80a9fc Compare April 25, 2024 13:49
@francoisfreitag francoisfreitag added modifié and removed 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC labels Apr 25, 2024
@francoisfreitag francoisfreitag changed the title Définir update_job_seeker comme URL de retour de select_job [GEN-8171] Candidatures : Corriger les URLs de retour du sélecteur de métiers [GEN-8171] Apr 25, 2024
xavfernandez
xavfernandez approved these changes Apr 26, 2024
View reviewed changes
tests/www/apply/test_submit.py Outdated Show resolved Hide resolved
@francoisfreitag francoisfreitag force-pushed the ff/update-jobseeker-info branch 2 times, most recently from f87b638 to aeaf341 Compare April 29, 2024 07:59
@francoisfreitag francoisfreitag added 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC and removed 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC labels Apr 29, 2024
@github-actions GitHub Actions
Copy link

🥁 La recette jetable est prête ! 👉 Je veux tester cette PR !

@francoisfreitag
Copy link
Contributor Author

Je viens de faire un commit séparé pour adresser les retours de recette de Marion :
https://itou-inclusion.slack.com/archives/CU8ATF54L/p1714391339948119?thread_ts=1712567070.966559&cid=CU8ATF54L

Pour les employeurs, on n’offre pas de bouton retour.

@francoisfreitag francoisfreitag force-pushed the ff/update-jobseeker-info branch 2 times, most recently from 4201d97 to fc53fdd Compare May 2, 2024 12:49
@francoisfreitag
Set select_job back_url to accessible views
60b7545 
Before this change, the select jobs back button directed users to
`check_prev_applications`, which redirects to the select jobs. Users
were thus directed to select jobs when they pressed back from select
jobs, which trick users into thinking the button doesn’t work.

Instead, point the back button to the beginning of the process for
prescribers and job seekers: the job description or employer card.

For employers, they are either declaring a hire or recording a job
application. In both case, they can simply go back to their dashboard.
@francoisfreitag francoisfreitag added this pull request to the merge queue May 2, 2024
Merged via the queue into master with commit 414ac6a May 2, 2024
10 of 11 checks passed
@francoisfreitag francoisfreitag deleted the ff/update-jobseeker-info branch May 2, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavfernandez xavfernandez xavfernandez approved these changes

@celine-m-s celine-m-s celine-m-s approved these changes

Assignees

@francoisfreitag francoisfreitag

Labels
1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC modifié
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@francoisfreitag @xavfernandez @celine-m-s