UX/UI : Filtrer les employeurs et postes de manière plus dynamique#3949
Merged
francoisfreitag merged 1 commit intomasterfrom Apr 29, 2024
Merged
UX/UI : Filtrer les employeurs et postes de manière plus dynamique#3949francoisfreitag merged 1 commit intomasterfrom
francoisfreitag merged 1 commit intomasterfrom
Conversation
francoisfreitag
force-pushed
the
ff/htmx-jobs
branch
from
f3fcb25 to
32eaad6
Compare
francoisfreitag
added
the
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
francoisfreitag
force-pushed
the
ff/htmx-jobs
branch
from
32eaad6 to
1324919
Compare
xavfernandez
approved these changes
Apr 18, 2024
Contributor
xavfernandez
left a comment
xavfernandez
left a comment
There was a problem hiding this comment.
C'est effectivement plus compliqué 😬
| @@ -0,0 +1,9 @@ | |||
| {% load django_bootstrap5 %} | |||
| <div id="company-field"{% if request.htmx %} hx-swap-oob="true"{% endif %}> | |||
Contributor
There was a problem hiding this comment.
Malin ce {% if request.htmx %} hx-swap-oob="true"{% endif %}.
francoisfreitag
force-pushed
the
ff/htmx-jobs
branch
from
1324919 to
233696b
Compare
Avoid reloading the entire page (and scrolling up) when a single filter changes. The goal is for the filter form not to be reloaded, to keep the current scroll position on the page and collapse state. This necessitated reorganizing the page so that the tabs, heading section and certain form fields can be reloaded independently with out-of-brand swaps. Purposely don’t move back to the top of the results. With the redesign in progress, the filters will move to the top of the page, removing the need to scroll. Also, as the filter list can be quite tall, users picking filters from the bottom of the page would be quite annoyed when the scroll position changes after they picked an element.
francoisfreitag
force-pushed
the
ff/htmx-jobs
branch
from
233696b to
70e5f4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Expérience utilisateur, moins de rechargement, moins de scroll.
🏝️ Comment tester
Attendu : pas de rechargement complet de la page lors de la sélection d’un filtre, animation de chargement sur la liste de résultats.
https://c1-review-ff-htmx-jobs.cleverapps.io/