Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX/UI : Filtrer les employeurs et postes de manière plus dynamique #3949

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

francoisfreitag
Copy link
Contributor

@francoisfreitag francoisfreitag commented Apr 18, 2024

🤔 Pourquoi ?

Expérience utilisateur, moins de rechargement, moins de scroll.

🏝️ Comment tester

  1. À partir de la page d’accueil
  2. Rechercher un métier et un poste

Attendu : pas de rechargement complet de la page lors de la sélection d’un filtre, animation de chargement sur la liste de résultats.

https://c1-review-ff-htmx-jobs.cleverapps.io/

@francoisfreitag francoisfreitag self-assigned this Apr 18, 2024
@francoisfreitag francoisfreitag added the 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC label Apr 18, 2024
Copy link

🥁 La recette jetable est prête ! 👉 Je veux tester cette PR !

Copy link
Contributor

@xavfernandez xavfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est effectivement plus compliqué 😬

itou/templates/search/includes/siaes_search_results.html Outdated Show resolved Hide resolved
itou/templates/search/includes/siaes_search_results.html Outdated Show resolved Hide resolved
@@ -0,0 +1,9 @@
{% load django_bootstrap5 %}
<div id="company-field"{% if request.htmx %} hx-swap-oob="true"{% endif %}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Malin ce {% if request.htmx %} hx-swap-oob="true"{% endif %}.

Copy link
Contributor

@hellodeloo hellodeloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏋️

itou/templates/search/includes/siaes_search_results.html Outdated Show resolved Hide resolved
Avoid reloading the entire page (and scrolling up) when a single filter
changes.

The goal is for the filter form not to be reloaded, to keep the current
scroll position on the page and collapse state. This necessitated
reorganizing the page so that the tabs, heading section and certain form
fields can be reloaded independently with out-of-brand swaps.

Purposely don’t move back to the top of the results. With the redesign
in progress, the filters will move to the top of the page, removing the
need to scroll. Also, as the filter list can be quite tall, users
picking filters from the bottom of the page would be quite annoyed when
the scroll position changes after they picked an element.
@francoisfreitag francoisfreitag added this pull request to the merge queue Apr 29, 2024
Merged via the queue into master with commit a5a54dd Apr 29, 2024
12 checks passed
@francoisfreitag francoisfreitag deleted the ff/htmx-jobs branch April 29, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC modifié
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants