Recherche employeur : amélioration de l’affichage lorsque le formulaire de recherche est invalide #4001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes multiple glitches due to missing context data on the page, when the form is invalid. Issues revealed by removing the `ignore_template_errors` mark. In order to make sure context is being shared between both the `form_valid()` and `form_invalid()` code paths, define it in `get_context_data()`.
tonial
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Plusieurs petits problèmes d’affichage, dont les compteurs qui n’étaient pas initialisés (badges vides sur les onglets), bouton retour manquant.
Les problèmes ont été révélés en enlevant le marqueur
ignore_template_errors.🍰 Comment ?
Afin de mutualiser la construction du contexte entre
form_valid()etform_invalid(), définition d’unget_context_data().💻 Captures d'écran
Avant
Après
🏝️ Comment tester
/search/employers/results?city=foo-44