Refactoring Branch #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use apache commons lang3 for NotImplemented exceptions
Avoid confusion with java Math class
|
Okey... Travis failed. It looks like the mathoid version is not running in travis. When I don't start Mathoid on my local machine, I got the same errors in the tests. When I start Mathoid, the tests finish successfully. @vstange Any idea what is missing in the travis config for MathMLConverters? |
|
@AndreG-P you spend soo much time to write the logs. Now you also have to read them |
|
mathoid didn't start see travis output on: MathMLConverters has a custom config for mathoid: https://github.com/ag-gipp/MathMLConverters/blob/master/config.dev.yaml |
by adding junit-jupiter-engine to maven surefire.
The config for mathoid is only necessary because of travis installations. So I moved it to the .travis folder. Also, an older version of mathoid is used (from https://git@github.com/physikerwelt/mathoid-server). We should fix this kind of tests!
This was referenced Feb 28, 2018
Splitted the original MathMLTools classes to mathml-core and mathml-utils.
Closed
Decided to move all loading, readers and writers for XML/MML to the core module.
Also updated the README.md and fix some bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@physikerwelt @vstange
I started to refactor MathMLTools as mentioned in #13
This branch contains now:
All tests except one (see #16) are finished successful on my machine (we will see what travis will show us...).
I don't know exactly why... Just before I start to refactor the project, I merged the WIP branch from Moritz #8 to master. I made some fixes but it looked like it worked. I merged it because I wanted the latest version in the refactored project (I presumed to solve merge conflicts after the refactoring will be a nightmare).
Besides this, I will change the naming a little bit further.
However, I'm more happy with the new structure. I need to setup the auto deployment system again, since it is a multi-module project now (see #15). Any suggestions for further improvements would be nice.
PS: I needed to merge the travis config also. We should definitely find another solution for this travis hack with mathoid. See gipplab/mathosphere#108