Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of maintainers #152

Closed
gerardtoconnor opened this issue Nov 24, 2017 · 11 comments
Closed

Number of maintainers #152

gerardtoconnor opened this issue Nov 24, 2017 · 11 comments

Comments

@gerardtoconnor
Copy link
Member

I think currently @dustinmoris (owner) may be the only maintainer of this project and with it picking up adoption and more PRs coming in regularly, it might be a good idea to add additional maintainers so that there is not an overwhelming burden of work on Dustin.

I think merging of PRs on design/api changes/expansions should be left to Dustin but if additional maintainers were added, would mean that urgent bug fixes could be merged quickly and free up Dustin a bit to focus on the release milestones & design etc.

Off the top of my head, @JonCanning or @forki would be good candidates to add as emergency maintainers who can push big fixes through with the understanding not to change the API drastically on merges.

@forki
Copy link
Contributor

forki commented Nov 24, 2017

I'm voting to promote @gerardtoconnor

@gerardtoconnor
Copy link
Member Author

I can do too if @forki is already stretched, happy for anyone else to throw their hat in too if they are up to it and have the familiarity with the full library. @slang25 @TheAngryByrd

@TheAngryByrd
Copy link
Member

I'll throw my hat in.

@dustinmoris
Copy link
Member

dustinmoris commented Nov 26, 2017

Hey guys, I think this is a great suggestion. I think for Giraffe to further succeed it is almost inevitable to add more maintainers, regardless of my own time, because even if I had nothing else to do other than 24/7 Giraffe it would be still necessary to add more maintainers to a project which gains wider adoption in order to further mature, add stability and promise longevity - so I'm happy to add a couple more maintainers at this point and see how it goes!

EDIT: Based on current responses I'd be happy to add @gerardtoconnor and @TheAngryByrd as maintainers - but I think all the other mentioned people here would be equally great if they want to do it!

(On a different side note - I was even considering to sign up for the .NET foundation thing, but need to understand a bit more what it means and what it gives. Would be awesome if the .NET foundation could be explained a bit more in depth on one of the ASP.NET team standups. /cc @jongalloway @shanselman)

@JonCanning
Copy link
Contributor

I'm happy to help. Exciting to see Giraffe gathering some momentum.

@dustinmoris
Copy link
Member

I'm just looking through the settings and playing around with what options I have to add collaborators and if there are any settings where I can define different team roles and who can do what on which branch and stuff like this... maybe I need to create an organisation though in order to have full control - sorry if I sent some notifications to some of you as part of playing around.

Any suggestions how to best organise this going forward?

@forki
Copy link
Contributor

forki commented Nov 26, 2017 via email

@gerardtoconnor
Copy link
Member Author

FSharp foundation is also an option? @forki has good familiarity with how big FSharp projects setup so organisation probably best way to go. Appreciate you probably need time to familiarise yourself with setup, it's foreign to me too.

@forki
Copy link
Contributor

forki commented Nov 28, 2017

so what's the plan?

@jongalloway
Copy link

I'd be happy to help if you'd like to apply to the .NET Foundation. FSharp Foundation would also make sense, it's really whichever you'd feel is a better fit.

The writeup of what .NET Foundation does is here: https://dotnetfoundation.org/about. There's also a video on the home page of the site if that's more your thing. Big picture is that open source software foundations exist to support projects by providing services (build servers, code signing, legal, etc.), governance (basically helping to make sure your project can stay around long-term and isn't tied to one person as a single point of failure), and adoption (helping with marketing, ability to "sell" your project better in the enterprise as a foundation supported project). I'd be happy to chat or talk to explain more. I agree it would make sense to talk more about it on a community standup some time.

I've worked closely with the FSharp Foundation leaders and there's absolutely no competition, I think either of us would say whichever seems like a better fit for your project.

@dustinmoris
Copy link
Member

Ok so I created an org now (giraffe-fsharp) and sent invites to @gerardtoconnor @TheAngryByrd and @JonCanning. I'll wait for them to accept the invite, then check what the permission situation looks like and then I'll move the project over.

@jongalloway Awesome, thanks for the info! I'll read through the docs and compare it to the fsharp foundation and then apply with one of them. If you happen to talk about the .NET foundation on a standup one day then I thought it would be interesting to hear some examples of where the foundation helped a project in some way so that people like me get perhaps a better idea of what to expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants