Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an example app using the cache features #553

Merged
merged 7 commits into from
Aug 31, 2023
Merged

Add an example app using the cache features #553

merged 7 commits into from
Aug 31, 2023

Conversation

64J0
Copy link
Member

@64J0 64J0 commented Aug 29, 2023 •
edited
Loading

Description

With this PR, I'm adding a new sample focused on the cache features.

How to test

It's described at the sample README.md that is going with this PR. In essence the instructions are:

First, start the server at the terminal using:

# Assuming that you're at the top level of this repository
dotnet run --project samples/ResponseCachingApp/

# It will start the server listening to port 5000

Now, you can use the test-run.fsx script:

dotnet fsi samples/ResponseCachingApp/test-run.fsx

Assert that it will make many requests to the server and show the time it took to finish the function call.

Related issues

@64J0 64J0 changed the base branch from master to develop August 30, 2023 11:09
@64J0
feat: add sample project to test the result caching middlewares from …
3323d35 
…Giraffe along with a script to automate the process and a README with instructions about the sample
@64J0 64J0 marked this pull request as ready for review August 30, 2023 12:24
TheAngryByrd
TheAngryByrd requested changes Aug 30, 2023
View reviewed changes
Copy link
Member

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Thank you! One small question before I approve it.

samples/ResponseCachingApp/test-run.sh Outdated Show resolved Hide resolved
@64J0 64J0 requested a review from TheAngryByrd August 30, 2023 20:21
@64J0 64J0 mentioned this pull request Aug 30, 2023
Closed
@64J0 64J0 marked this pull request as draft August 30, 2023 21:39
@64J0
Copy link
Member Author

64J0 commented Aug 30, 2023

I'm moving this PR back to draft while addressing @RonaldSchlenker's suggestions to the fsx script.

@64J0 64J0 marked this pull request as ready for review August 30, 2023 22:00
TheAngryByrd
TheAngryByrd approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@TheAngryByrd TheAngryByrd merged commit cf04266 into giraffe-fsharp:develop Aug 31, 2023
5 checks passed
@64J0 64J0 deleted the add-cache-sample branch August 31, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAngryByrd TheAngryByrd TheAngryByrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@64J0 @TheAngryByrd