Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to .net 8 #574

Merged
merged 8 commits into from
Mar 15, 2024
Merged

Update to .net 8 #574

merged 8 commits into from
Mar 15, 2024

Conversation

fpellet
Copy link
Contributor

@fpellet fpellet commented Jan 22, 2024

Description

Add .net 8 and upgrade dependencies.
Add upgrade dependencies of #566

How to test

Building the solution, running tests, and running the sample endpoint app

Related issues

Close #570
Close #565

@64J0
Copy link
Member

64J0 commented Feb 25, 2024

Just a first heads-up, can you please target the develop branch instead of master? The contributing workflow is documented here: https://github.com/giraffe-fsharp/Giraffe?tab=readme-ov-file#contributing.

@fpellet
Copy link
Contributor Author

fpellet commented Mar 10, 2024

@64J0 done. Sorry for the delay, I forgot to do it 😅

@64J0 64J0 changed the base branch from master to develop March 14, 2024 00:54
64J0
64J0 previously approved these changes Mar 15, 2024
Copy link
Member

@64J0 64J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally using the samples with different .NET versions and it worked fine. Thanks for the PR!

RELEASE_NOTES.md Outdated Show resolved Hide resolved
@64J0 64J0 merged commit 484c761 into giraffe-fsharp:develop Mar 15, 2024
5 checks passed
@64J0 64J0 mentioned this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Giraffe 6.2 is breaks against Microsoft.IO.RecyclableMemoryStream 3.0.0 Upgrade to .NET 8
4 participants