New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add objectPosition. #177

Merged

giraud merged 2 commits into giraud:master from damianfral:master

Feb 4, 2020

Contributor

damianfral commented Dec 30, 2019

Just used the same types that BackgroundPositions uses.


          Add objectPosition and objectPositions.

95aa06a

Owner

giraud commented Jan 6, 2020

Hi, thank you for the PR.
Reading https://developer.mozilla.org/fr/docs/Web/CSS/object-position, I don't see the need for an objectPositions. is that correct ?
Adding minimal tests might be all we need to validate the behavior.


          Remove objectPositions.

giraud merged commit 9441b18 into giraud:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment