-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type inference #348
Type inference #348
Conversation
No problem. Unfortunately, I have to refuse this one.
|
I was half-expecting it, but it's unfortunate. I really want to provide better more features support for OCaml, especially outside IntelliJ (PHPStorm/PyCharm/...) and without a build tool. Do you think you will be fine if I use your code as a foundation of a plugin focused on OCaml (without dune, esy, reason, etc.)? I think that may be the only way to do what I want, unfortunately😔. |
Yes, you can fork this project and do whatever you want. This is MIT licence. No problem on my side. That being said, I can think of another path. Right now, OCaml projects are not supported outside IntelliJ product because I am using code based on the SdkType class and it is only available for Java based IDE. It was easier and faster to implement a basic behavior based on the SDK base class. So, if you're going to do some work to enable OCaml for these IDE, and if something clean and easy to understand/implement can be found, it could be cool to do it in this plugin first. This part I don't know Then I think that you could develop a plugin that depends on this one to provide custom features (build system based on a makefile). And, ultimately, in the case we can't agree, you'll have the option to fork it. |
Understood! I will try to understand the code first, and learn more about what you did. If I'm able to make something, I will make a PR, so you can see what I'm doing. Thanks! |
maybe before a PR it's good to try visualise/explain what need to be done,how. |
Understood, I will start a discussion later, thanks for the advice 👍 |
Hello, again!
If we are compiling files manually (either with ocamlc or a Makefile+ocamlc), the type inference is not available (as this is not one of the supported tools). I added something in the Settings allowing the user to pick the version of OCaml
Sorry for the bunch of pull requests 🙇♂️, I'm almost done (I think?)