Ensure that a text input doesn't appear after downloading checked items #2736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a problem in the web client where a text input appears at the bottom of the page after checking items and selecting "Download checked resources". To avoid long query strings in GET requests--in case a large number of files are checked--this download mechanism creates and submits a temporary form. For compatibility with Firefox, the form must be in the DOM for submission to work. This commit removes the temporary form from the DOM after it's submitted.
manthey
approved these changes
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a problem in the web client where a text input appears at the bottom of the page after checking items and selecting "Download checked resources".
To avoid long query strings in GET requests--in case a large number of files are checked--this download mechanism creates and submits a temporary form. For compatibility with Firefox, the form must be in the DOM for submission to work.
This commit removes the temporary form from the DOM after it's submitted.
Screenshot of the old behavior after downloading:
