Fix overcaching annotations.

This was caused by #978.
girder · Oct 19, 2022 · ae8b48b · ae8b48b
1 parent 1a7ba44
commit ae8b48b
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Change Log
 
+## 1.17.2
+
+### Bug Fixes
+- Fixed overcaching annotations ([#983](../../pull/983))
+
 ## 1.17.1
 
 ### Improvements

diff --git a/girder_annotation/girder_large_image_annotation/web_client/models/AnnotationModel.js b/girder_annotation/girder_large_image_annotation/web_client/models/AnnotationModel.js
@@ -31,6 +31,9 @@ let AnnotationModel = AccessControlledModel.extend({
     },
 
     initialize() {
+        if (!this.get('updated')) {
+            this.attributes.updated = '' + Date.now(); // eslint-disable-line backbone/no-model-attributes
+        }
         this._region = {
             maxDetails: this.get('maxDetails'),
             sort: 'size',
@@ -61,7 +64,10 @@ let AnnotationModel = AccessControlledModel.extend({
         var url = (this.altUrl || this.resourceName) + '/' + this.get('_id');
         var restOpts = {
             url: url,
-            data: {sort: 'size', sortdir: -1, centroids: true, limit: this.get('maxCentroids')},
+            data: {
+                sort: 'size', sortdir: -1, centroids: true, limit: this.get('maxCentroids'),
+                _: (this.get('updated') || this.get('created')) + '_' + this.get('_version')
+            },
             xhrFields: {
                 responseType: 'arraybuffer'
             },
@@ -180,7 +186,7 @@ let AnnotationModel = AccessControlledModel.extend({
         var restOpts = {
             url: (this.altUrl || this.resourceName) + '/' + this.get('_id'),
             /* Add our region request into the query */
-            data: this._region
+            data: Object.assign({}, this._region, {_: (this.get('updated') || this.get('created')) + '_' + this.get('_version')})
         };
         if (opts.extraPath) {
             restOpts.url += '/' + opts.extraPath;
@@ -280,6 +286,7 @@ let AnnotationModel = AccessControlledModel.extend({
         } else {
             url = `annotation/${this.id}`;
             method = 'PUT';
+            this.attributes.updated = '' + Date.now(); // eslint-disable-line backbone/no-model-attributes
         }
 
         if (this._pageElements === false || isNew) {
@@ -339,6 +346,7 @@ let AnnotationModel = AccessControlledModel.extend({
         this.trigger('g:delete', this, this.collection, options);
         let xhr = false;
         if (!this.isNew()) {
+            this.attributes.updated = '' + Date.now(); // eslint-disable-line backbone/no-model-attributes
             xhr = restRequest({
                 url: `annotation/${this.id}`,
                 method: 'DELETE'

diff --git a/girder_annotation/test_annotation/web_client_specs/annotationSpec.js b/girder_annotation/test_annotation/web_client_specs/annotationSpec.js
@@ -451,10 +451,12 @@ describe('Annotations', function () {
         it('destroy an existing annotation', function () {
             var done;
 
-            annotation.destroy().done(function () {
-                done = true;
-            }).fail(function (resp) {
-                console.error(resp);
+            runs(function () {
+                annotation.destroy().done(function () {
+                    done = true;
+                }).fail(function (resp) {
+                    console.error(resp);
+                });
             });
             waitsFor(function () {
                 return done;