Use importlib.metadata instead of pkg_resources. #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+52
to
+55
| try: | ||
| from importlib.metadata import entry_points | ||
| except ImportError: | ||
| from importlib_metadata import entry_points |
There was a problem hiding this comment.
If this is now a hard dependency and importlib.metadata is a part of stdlib >=3.8, then, in my opinion, this should be with the rest of the imports at the top of the file
| @@ -77,6 +77,7 @@ def prerelease_local_scheme(version): | |||
| 'Pillow!=8.3.0,!=8.3.1', | |||
| 'psutil>=4.2.0', # technically optional | |||
| 'numpy>=1.10.4', | |||
| 'importlib-metadata ; python_version < "3.8"', | |||
There was a problem hiding this comment.
@manthey, on the next release, I need to make sure this is captured in the conda recipe for py3.7
There was a problem hiding this comment.
Mostly a reminder for myself, and hoping you'll remind me if I forget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #452.