Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server / Python Client: Require "version" when uploading application packages #97

Merged
merged 4 commits into from
Jun 8, 2021
Merged

Server / Python Client: Require "version" when uploading application packages #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0cc6efb
test_python_client: Improve consistency of draft release revisions
jcfr Jun 6, 2021
8a15bb5
test_python_client: Update packages fixture to consistently set revision
jcfr Jun 7, 2021
6fec09c
test_client_cli: Re-order input data keys to match "test_python_clien…
jcfr Jun 7, 2021
dec3a0c
Server / Python Client: Require "version" when uploading application …
jcfr Jun 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@ Release Notes
This is the list of **Slicer Package Manager** changes between each release. For full
details, see the commit logs at https://github.com/girder/slicer_package_manager

Next Release
============

New Features
------------

* Require version information to be specified when uploading application packages. See :issue:`97`.


0.4.0
=====
Expand Down Expand Up @@ -37,12 +45,12 @@ Server
* Update implementation of ``GET /app/:app_id/package`` endpoint to properly handle
``limit=0`` parameter. See :issue:`94`.


Documentation
-------------

* Add documentation to :func:`slicer_package_manager.utilities.getOrCreateReleaseFolder`.


0.2.0
=====

Expand Down
4 changes: 2 additions & 2 deletions plugin_tests/python_client_tests/cassettes/testCreateRelease.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ interactions:
[{"flags": [], "id": "5f081a506e4717a84202fd10", "level": 2}]}, "baseParentId":
"609995b20657dd063969294d", "baseParentType": "collection", "created": "2021-05-10T23:02:29.090840+00:00",
"creatorId": "5f081a506e4717a84202fd10", "description": "", "lowerName": "release",
"meta": {"revision": "r000"}, "name": "Release", "parentCollection": "folder",
"meta": {"revision": "r000", "version": "1.0"}, "name": "Release", "parentCollection": "folder",
"parentId": "6099bb850657dd0639692b55", "public": true, "size": 0, "updated":
"2021-05-10T23:02:29.092311+00:00"}'
headers:
Expand Down Expand Up @@ -457,7 +457,7 @@ interactions:
[{"flags": [], "id": "5f081a506e4717a84202fd10", "level": 2}]}, "baseParentId":
"609995b20657dd063969294d", "baseParentType": "collection", "created": "2021-05-10T23:02:29.090000+00:00",
"creatorId": "5f081a506e4717a84202fd10", "description": "", "lowerName": "release",
"meta": {"revision": "r000"}, "name": "Release", "parentCollection": "folder",
"meta": {"revision": "r000", "version": "1.0"}, "name": "Release", "parentCollection": "folder",
"parentId": "6099bb850657dd0639692b55", "public": true, "size": 0, "updated":
"2021-05-10T23:02:29.092000+00:00"}'
headers:
Expand Down
4 changes: 2 additions & 2 deletions plugin_tests/python_client_tests/cassettes/testCreateReleaseCLI.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ interactions:
[{"flags": [], "id": "5f081a506e4717a84202fd10", "level": 2}]}, "baseParentId":
"609995b20657dd063969294d", "baseParentType": "collection", "created": "2021-05-10T23:01:51.373714+00:00",
"creatorId": "5f081a506e4717a84202fd10", "description": "", "lowerName": "release",
"meta": {"revision": "r000"}, "name": "Release", "parentCollection": "folder",
"meta": {"revision": "r000", "version": "1.0"}, "name": "Release", "parentCollection": "folder",
"parentId": "6099bb5e0657dd0639692aa9", "public": true, "size": 0, "updated":
"2021-05-10T23:01:51.375093+00:00"}'
headers:
Expand Down Expand Up @@ -586,7 +586,7 @@ interactions:
[{"flags": [], "id": "5f081a506e4717a84202fd10", "level": 2}]}, "baseParentId":
"609995b20657dd063969294d", "baseParentType": "collection", "created": "2021-05-10T23:01:51.373000+00:00",
"creatorId": "5f081a506e4717a84202fd10", "description": "", "lowerName": "release",
"meta": {"revision": "r000"}, "name": "Release", "parentCollection": "folder",
"meta": {"revision": "r000", "version": "1.0"}, "name": "Release", "parentCollection": "folder",
"parentId": "6099bb5e0657dd0639692aa9", "public": true, "size": 0, "updated":
"2021-05-10T23:01:51.375000+00:00"}'
headers:
Expand Down
20 changes: 10 additions & 10 deletions plugin_tests/python_client_tests/cassettes/testDeleteDraftCLI.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,15 +414,15 @@ interactions:
User-Agent:
- python-requests/2.18.4
method: POST
uri: http://localhost:8080/api/v1//app/609ef29cce219e6bff5148f2/package?os=macosx&arch=i386&baseName=pkg1&repository_type=git&repository_url=git%40github.com%3Apkg1.git&revision=r002&description=
uri: http://localhost:8080/api/v1//app/609ef29cce219e6bff5148f2/package?os=macosx&arch=i386&baseName=pkg1&repository_type=git&repository_url=git%40github.com%3Apkg1.git&revision=r002&version=3.0&description=
response:
body:
string: '{"_id": "609ef29cce219e6bff5148f7", "baseParentId": "609995b20657dd063969294d",
"baseParentType": "collection", "created": "2021-05-14T21:58:52.768984+00:00",
"creatorId": "5f081a506e4717a84202fd10", "description": "", "folderId": "609ef29cce219e6bff5148f6",
"lowerName": "pkg1_macosx_i386_r002", "meta": {"app_id": "609ef29cce219e6bff5148f2",
"arch": "i386", "baseName": "pkg1", "os": "macosx", "repository_type": "git",
"repository_url": "git@github.com:pkg1.git", "revision": "r002"}, "name":
"repository_url": "git@github.com:pkg1.git", "revision": "r002", "version": "3.0"}, "name":
"pkg1_macosx_i386_r002", "size": 0, "updated": "2021-05-14T21:58:52.770271+00:00"}'
headers:
Allow:
Expand Down Expand Up @@ -736,15 +736,15 @@ interactions:
User-Agent:
- python-requests/2.18.4
method: POST
uri: http://localhost:8080/api/v1//app/609ef29cce219e6bff5148f2/package?os=macosx&arch=amd64&baseName=pkg2&repository_type=git&repository_url=git%40github.com%3Apkg2.git&revision=r002&description=
uri: http://localhost:8080/api/v1//app/609ef29cce219e6bff5148f2/package?os=macosx&arch=amd64&baseName=pkg2&repository_type=git&repository_url=git%40github.com%3Apkg2.git&revision=r002&version=3.0&description=
response:
body:
string: '{"_id": "609ef29dce219e6bff5148fa", "baseParentId": "609995b20657dd063969294d",
"baseParentType": "collection", "created": "2021-05-14T21:58:53.099614+00:00",
"creatorId": "5f081a506e4717a84202fd10", "description": "", "folderId": "609ef29cce219e6bff5148f6",
"lowerName": "pkg2_macosx_amd64_r002", "meta": {"app_id": "609ef29cce219e6bff5148f2",
"arch": "amd64", "baseName": "pkg2", "os": "macosx", "repository_type": "git",
"repository_url": "git@github.com:pkg2.git", "revision": "r002"}, "name":
"repository_url": "git@github.com:pkg2.git", "revision": "r002", "version": "3.0"}, "name":
"pkg2_macosx_amd64_r002", "size": 0, "updated": "2021-05-14T21:58:53.100981+00:00"}'
headers:
Allow:
Expand Down Expand Up @@ -1058,15 +1058,15 @@ interactions:
User-Agent:
- python-requests/2.18.4
method: POST
uri: http://localhost:8080/api/v1//app/609ef29cce219e6bff5148f2/package?os=win&arch=i386&baseName=pkg3&repository_type=git&repository_url=git%40github.com%3Apkg3.git&revision=r002&description=
uri: http://localhost:8080/api/v1//app/609ef29cce219e6bff5148f2/package?os=win&arch=i386&baseName=pkg3&repository_type=git&repository_url=git%40github.com%3Apkg3.git&revision=r002&version=3.0&description=
response:
body:
string: '{"_id": "609ef29dce219e6bff5148fd", "baseParentId": "609995b20657dd063969294d",
"baseParentType": "collection", "created": "2021-05-14T21:58:53.435150+00:00",
"creatorId": "5f081a506e4717a84202fd10", "description": "", "folderId": "609ef29cce219e6bff5148f6",
"lowerName": "pkg3_win_i386_r002", "meta": {"app_id": "609ef29cce219e6bff5148f2",
"arch": "i386", "baseName": "pkg3", "os": "win", "repository_type": "git",
"repository_url": "git@github.com:pkg3.git", "revision": "r002"}, "name":
"repository_url": "git@github.com:pkg3.git", "revision": "r002", "version": "3.0"}, "name":
"pkg3_win_i386_r002", "size": 0, "updated": "2021-05-14T21:58:53.436467+00:00"}'
headers:
Allow:
Expand Down Expand Up @@ -1380,15 +1380,15 @@ interactions:
User-Agent:
- python-requests/2.18.4
method: POST
uri: http://localhost:8080/api/v1//app/609ef29cce219e6bff5148f2/package?os=linux&arch=amd64&baseName=pkg4&repository_type=git&repository_url=git%40github.com%3Apkg4.git&revision=r003&description=
uri: http://localhost:8080/api/v1//app/609ef29cce219e6bff5148f2/package?os=linux&arch=amd64&baseName=pkg4&repository_type=git&repository_url=git%40github.com%3Apkg4.git&revision=r003&version=3.0&description=
response:
body:
string: '{"_id": "609ef29dce219e6bff514901", "baseParentId": "609995b20657dd063969294d",
"baseParentType": "collection", "created": "2021-05-14T21:58:53.813783+00:00",
"creatorId": "5f081a506e4717a84202fd10", "description": "", "folderId": "609ef29dce219e6bff514900",
"lowerName": "pkg4_linux_amd64_r003", "meta": {"app_id": "609ef29cce219e6bff5148f2",
"arch": "amd64", "baseName": "pkg4", "os": "linux", "repository_type": "git",
"repository_url": "git@github.com:pkg4.git", "revision": "r003"}, "name":
"repository_url": "git@github.com:pkg4.git", "revision": "r003", "version": "3.0"}, "name":
"pkg4_linux_amd64_r003", "size": 0, "updated": "2021-05-14T21:58:53.815017+00:00"}'
headers:
Allow:
Expand Down Expand Up @@ -1673,7 +1673,7 @@ interactions:
[{"flags": [], "id": "5f081a506e4717a84202fd10", "level": 2}]}, "baseParentId":
"609995b20657dd063969294d", "baseParentType": "collection", "created": "2021-05-14T21:58:52.766000+00:00",
"creatorId": "5f081a506e4717a84202fd10", "description": "", "lowerName": "r002",
"meta": {"revision": "r002"}, "name": "r002", "parentCollection": "folder",
"meta": {"revision": "r002", "version": "3.0"}, "name": "r002", "parentCollection": "folder",
"parentId": "609ef29cce219e6bff5148f3", "public": true, "size": 84, "updated":
"2021-05-14T21:58:52.767000+00:00"}]'
headers:
Expand Down Expand Up @@ -1715,7 +1715,7 @@ interactions:
[{"flags": [], "id": "5f081a506e4717a84202fd10", "level": 2}]}, "baseParentId":
"609995b20657dd063969294d", "baseParentType": "collection", "created": "2021-05-14T21:58:52.766000+00:00",
"creatorId": "5f081a506e4717a84202fd10", "description": "", "lowerName": "r002",
"meta": {"revision": "r002"}, "name": "r002", "parentCollection": "folder",
"meta": {"revision": "r002", "version": "3.0"}, "name": "r002", "parentCollection": "folder",
"parentId": "609ef29cce219e6bff5148f3", "public": true, "size": 84, "updated":
"2021-05-14T21:58:52.767000+00:00"}'
headers:
Expand Down