Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid size props are passed #172

Closed
rohan-kulkarni-25 opened this issue Apr 4, 2023 · 2 comments
Closed

Invalid size props are passed #172

rohan-kulkarni-25 opened this issue Apr 4, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@rohan-kulkarni-25
Copy link
Contributor

Description

What is the problem you are facing

When I deployed the project on my local system and was doing some random changes I noticed that in the console a warning is shown.

Screenshot from 2023-04-04 15-36-55

I just went through the code and found it in Waypoint. jsx size props are directly passed as 32px This was the reason for the warning.

What is your suggested solution

As we are following the proper syntax of tiny and small we should use the same variables here.
I have made the changes to check if is this only the reason for the error.

Screenshot from 2023-04-04 15-44-14

And yes the errors were gone. I hope this will help to maintain our code consistency, I am also submitting my proposal under this project in gsoc. Would love to make more such changes which will help us to maintain code consistency and improve our web app UI.

Thanks

Screenshots

No response

@nilsnolde
Copy link
Member

Thanks for this. GSoC is finished though, sorry. I mean you can apply still, but it's been too many good applicants already to be considered at this point.

@rohan-kulkarni-25
Copy link
Contributor Author

Thanks for this. GSoC is finished though, sorry. I mean you can apply still, but it's been too many good applicants already to be considered at this point.

Ahh, no worries. Would love to apply still as I am interested to contribute on this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants