Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment fault #24

Open
vtao1989 opened this issue Nov 16, 2022 · 4 comments
Open

Segment fault #24

vtao1989 opened this issue Nov 16, 2022 · 4 comments

Comments

@vtao1989
Copy link

Package and system information: pyvalhalla 3.0.3 with python 3.10.6 in the Debian Linux 11.

My task was to map match several trips to the roads. The issue was that, after trace_route returned a RuntimeError with "Exact route match algorithm failed to find path" when map matching a trip, map matching another trip caused the "Segment fault" error.

@nilsnolde
Copy link
Member

I can't see how this causes a segfault within Valhalla (let alone the bindings, we don't do anything special here):

https://github.com/valhalla/valhalla/blob/5f59706b8a172f8e664835f79f1928c2de8fb837/src/thor/trace_route_action.cc#L84-L92

Can you provide a minimum example request (as few points as possible)?

@vtao1989
Copy link
Author

Sure.

You can find the code and data in this repo. The data contains GPS points of two trips.

I used the tiles built from PA, US. The repo does not allow me to upload large-size files. So you probably need to build tiles by yourself. Sorry for the inconvenience.

I tested this code in Windows and Linux, and the same issue occurred on both.

Thanks.

@nikosece
Copy link

nikosece commented May 2, 2023

I had the same issue. In my case it was solved after increasing the trace_options.search_radius to 50 meters

@nilsnolde
Copy link
Member

nilsnolde commented May 2, 2023

Also windows? Did you try other OSs?

Oops, @vtao1989 was also on Linux.. Do you have an easier way to replicate by any chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants