Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wheel build for win #3

Closed
nilsnolde opened this issue Dec 29, 2021 · 1 comment · Fixed by #5
Closed

fix wheel build for win #3

nilsnolde opened this issue Dec 29, 2021 · 1 comment · Fixed by #5

Comments

@nilsnolde
Copy link
Member

nilsnolde commented Dec 29, 2021 •
edited

it appears that mvsc does not copy the dependency .dll's to the python distribution (it does do that with valhalla's cmake). so we need another tool similar to auditwheel & delocate. seems that https://github.com/adang1345/delvewheel is a good option. even cibuildwheel considered using it by default.
@nilsnolde
Copy link
Member Author

important for CI: the default GA win-latest runner has vcpkg installed by default: https://github.com/actions/virtual-environments/blob/main/images/win/Windows2019-Readme.md#environment-variables. that's great so we can ditch the terrible workaround I did for valhalla's azure ci.

@nilsnolde nilsnolde mentioned this issue Jan 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Solve CI and publishing on PyPI gis-ops/pyvalhalla
1 participant
@nilsnolde