Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jupyter notebooks as document type #2

Closed
nilsnolde opened this issue Mar 3, 2020 · 6 comments · Fixed by #9
Closed

Add Jupyter notebooks as document type #2

nilsnolde opened this issue Mar 3, 2020 · 6 comments · Fixed by #9
Labels
enhancement New feature or request
Milestone

Comments

@nilsnolde
Copy link
Member

Could replace the nbconvert plugin by @ghandic. Let me know in case you're interested in contributing.

@ghandic
Copy link

ghandic commented Mar 3, 2020

I have used nbviewer to render the notebooks, notebooks need to be converted to html from ipynb. If this is incorporated into this repo it could be used

@nilsnolde
Copy link
Member Author

Jup, I’d do the same actually here as well. To render the markdown I also send it to githubs rendering endpoint. Should be a quick one to incorporate notebooks via nbviewer and best thing, it’s platform independent.

BTW the whole idea is inspired by your WP plugin. I also „stole“ your checkout link stuff. Reminds me I need to make your contribution more prominent in the README.

@nilsnolde nilsnolde added this to the v1.1 milestone Mar 7, 2020
@nilsnolde nilsnolde added the enhancement New feature or request label Mar 7, 2020
@nilsnolde
Copy link
Member Author

This is done now in this plugin @ghandic. I'll release it in ~ 1 week on the WP plugin repo. Thanks for your previous work especially regarding the CSS!

@nilsnolde nilsnolde modified the milestones: v1.1, v1.0 Mar 8, 2020
@ghandic
Copy link

ghandic commented Mar 8, 2020

Awesome, have you updated the readme?

@nilsnolde
Copy link
Member Author

It's what you see right now. If you want to suggest edits, feel free.

@ghandic
Copy link

ghandic commented Mar 8, 2020

Ahh ok, just wondering as you said you need to make the contribution section more prominent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants