Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactions #4

Closed
wants to merge 2 commits into from
Closed

Interactions #4

wants to merge 2 commits into from

Conversation

gisachris
Copy link
Owner

@gisachris gisachris commented May 12, 2023

IN This PR I present the To-Do-List app Interactions :

Below are some of my implementations as well as going over the project requirements 🀝 .

Requirements

-Add a new JavaScript file and import it as a module πŸ“œ
-the script should contain methods related to the status updates (completed: true / false). πŸŽ‰
-Add event listener to the checkbox (change). πŸ₯‡
-Update items object's value for the completed key upon user actions. 🟑
-Implement a function for the "Clear all completed" button (use filter() method). πŸ”Ž
-Store the updated array of items in local storage πŸ”’

Achievements

-Create a new JavaScript file for the new Interactions.βœ…
-add the necessary logic 🧠 to add and remove items to the list and to the Dom πŸ“œ βœ…
-By default, new tasks should have the property completed set to false and the index set to the value of the arraylengthβœ…
-Add event listener to the checkbox (change). πŸ₯‡
-Update items object's value for the completed key upon user actions. 🟑
-Deleting a task should update all remaining items' indexes.βœ…
-All changes to the To Do List should be saved in local storage.βœ…
-add styling 🎨 based on the list structure given βœ…

Conclusion

I would love to hear πŸ‘‚ from you my CR in terms of what can be better implemented πŸ‘¨β€πŸ’» for the site thankyou!. And I look forward to hearing from you soon. πŸ™‡

@gisachris gisachris closed this May 12, 2023
@gisachris gisachris deleted the interaction branch May 12, 2023 11:14
Copy link

@wayungi wayungi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

..

Copy link

@rotimiazeez rotimiazeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gisachris ,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a PR that is closed and can not be reviewed. Kindly submit an open PR so it can be reviewed.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready πŸ™

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request Does not count into the code reviews limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants