Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide the ArlasColorService globally #754

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Provide the ArlasColorService globally #754

merged 1 commit into from
Oct 31, 2023

Conversation

MohamedHamouGisaia
Copy link
Member

@MohamedHamouGisaia MohamedHamouGisaia commented Oct 31, 2023 •
edited

@MohamedHamouGisaia
Provide the ArlasColorService globally
e47e6c4 
- this is to avoid duplicate instances of the service in case of lazy loading modules
@MohamedHamouGisaia MohamedHamouGisaia merged commit 38696a2 into feat/24.3.0 Oct 31, 2023
1 check passed
@MohamedHamouGisaia MohamedHamouGisaia deleted the fix/colorService branch October 31, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebbousquet sebbousquet sebbousquet approved these changes

@QuCMGisaia QuCMGisaia QuCMGisaia approved these changes

@mbarbet mbarbet Awaiting requested review from mbarbet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MohamedHamouGisaia @sebbousquet @QuCMGisaia