Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle 0 integer as valid value #47

Merged
merged 3 commits into from
Oct 13, 2016
Merged

Properly handle 0 integer as valid value #47

merged 3 commits into from
Oct 13, 2016

Conversation

abbse
Copy link
Contributor

@abbse abbse commented Oct 4, 2016

Properly handle 0 integer as valid value otherwise tag is not created

@coveralls
Copy link

coveralls commented Oct 4, 2016 •
edited

Coverage Status

Coverage remained the same at 73.446% when pulling 9919b5b on Som-Energia:master into c4e492b on gisce:master.

@ecarreras
Copy link
Member

Thank you for this PR, can you add a test to ensure this feature.

@coveralls
Copy link

coveralls commented Oct 5, 2016 •
edited

Coverage Status

Coverage increased (+0.6%) to 74.011% when pulling 03e79b4 on Som-Energia:master into c4e492b on gisce:master.

@coveralls
Copy link

coveralls commented Oct 6, 2016 •
edited

Coverage Status

Coverage increased (+1.1%) to 74.576% when pulling 803eee1 on Som-Energia:master into c4e492b on gisce:master.

@tinogis tinogis merged commit a8a2789 into gisce:master Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abbse @coveralls @ecarreras @tinogis