Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed production dependencies #1343

Merged
merged 1 commit into from Apr 7, 2024
Merged

Fixed production dependencies #1343

merged 1 commit into from Apr 7, 2024

Conversation

crycode-de
Copy link
Contributor

The node modules @next/bundle-analyzer and next-translate-plugin are required at runtime but defined as devDependencies in package.json.
So when installing production modules only, giscus will not start.

Steps to reproduce:

  1. yarn install
  2. yarn build
  3. yarn start - working
  4. rm -r node_modules
  5. yarn install --production
  6. yarn start - not working since @next/bundle-analyzer and next-translate-plugin missing

Copy link

vercel bot commented Apr 2, 2024

@crycode-de is attempting to deploy a commit to the giscus Team on Vercel.

A member of the Team first needs to authorize it.

@next/bundle-analyzer and next-translate-plugin are required at runtime
Copy link

vercel bot commented Apr 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giscus ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2024 3:52am

@laymonage laymonage merged commit eb02fe0 into giscus:main Apr 7, 2024
2 checks passed
@laymonage
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants