Fix dump($1) when $1 was numeric

gisle · Oct 14, 2011 · 6caed8a · 6caed8a
1 parent 97119d4
commit 6caed8a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/lib/Data/Dump.pm b/lib/Data/Dump.pm
@@ -232,8 +232,8 @@ sub _dump
 	    if (!defined $$rval) {
 		$out = "undef";
 	    }
-	    elsif ($$rval =~ /^-?[1-9]\d{0,9}\z/ || $$rval eq "0") {
-		$out = $$rval;
+	    elsif (my $v = "$$rval", $$rval =~ /^-?[1-9]\d{0,9}\z/ || $$rval eq "0") {
+		$out = $v;
 	    }
 	    else {
 		$out = str($$rval);

diff --git a/t/dollar-one.t b/t/dollar-one.t
@@ -1,6 +1,6 @@
 use strict;
 use warnings;
-use Test::More tests => 4;
+use Test::More tests => 6;
 
 use Data::Dump qw/dump/;
 
@@ -11,6 +11,7 @@ if ("abc" =~ /(.+)/) {
 }
 
 if ("123" =~ /(.+)/) {
-    local $TODO = '$1 still modified by dump itself';
     is(dump($1), "123");
+    is(dump(\$1), '\123');
+    is(dump([$1]), '[123]');
 }