New tests for when __FILE__ is relative #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you have any feedback on this PR (positive or negative) I would be interested to receive it. Thanks. |
abh
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SSL_ca_file the branch to turn the relative path to the bundle file into an absolute one is not tested by default (neither on my system nor at cpancover). This PR is a simple new test file to ensure that it is tested and thus complete the coverage.
I've been assigned this dist as part of the CPAN PR Challenge and it seems to be in really good shape. Even most of the open RT tickets are either actually resolved or apparently unresolvable. So if there is anything in particular you would like me to take a look at this month do let me know. Other than this sort of housekeeping there's not much else I can see needs to be done.