New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tests for when __FILE__ is relative #8

Merged
merged 1 commit into from Sep 7, 2018

Conversation

Projects
None yet
2 participants
@openstrike
Contributor

openstrike commented May 2, 2016

In SSL_ca_file the branch to turn the relative path to the bundle file into an absolute one is not tested by default (neither on my system nor at cpancover). This PR is a simple new test file to ensure that it is tested and thus complete the coverage.

I've been assigned this dist as part of the CPAN PR Challenge and it seems to be in really good shape. Even most of the open RT tickets are either actually resolved or apparently unresolvable. So if there is anything in particular you would like me to take a look at this month do let me know. Other than this sort of housekeeping there's not much else I can see needs to be done.

@openstrike

This comment has been minimized.

Contributor

openstrike commented Sep 6, 2018

If you have any feedback on this PR (positive or negative) I would be interested to receive it. Thanks.

@abh

abh approved these changes Sep 7, 2018

@abh abh merged commit 98c0c69 into gisle:master Sep 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment