Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[>=0.10.0] Argument --processed stopped producing healthy output #197

Closed
oCCtet opened this issue Mar 21, 2022 · 2 comments · Fixed by #199
Closed

[>=0.10.0] Argument --processed stopped producing healthy output #197

oCCtet opened this issue Mar 21, 2022 · 2 comments · Fixed by #199
Assignees
Labels
Milestone

Comments

@oCCtet
Copy link

oCCtet commented Mar 21, 2022

What is the purpose of --processed option nowadays? It used to output the big picture in the requested format; v1.2.0 outputs a Python bytes literal which IMHO makes no sense. Please see below:

$ ./git-big-picture-v0.9.0 --format=svg -pVO | xmllint -noout -
$ git big-picture --format=svg -pVO | xmllint -noout -
-:1: parser error : Start tag expected, '<' not found
b'<?xml version="1.0" encoding="UTF-8" standalone="no"?>\n<!DOCTYPE svg PUBLIC "
^

I found the old behavior useful and sane.

Br. Sami

@hartwork hartwork added the bug label Mar 21, 2022
@hartwork
Copy link
Member

hartwork commented Mar 21, 2022

Hi @oCCtet , thanks for bringing this to attention. I confirm this behavior as a bug. My guess is that it's a regression from the migration to Python 3. I'm optimistic this can be fixed shortly.

Please note that use of versions <1.0.0 is not advised today because these are vulnerable to security issue CVE-2021-3028. (In case that was your plan for a workaround while waiting for the fix.)

@hartwork hartwork changed the title The --processed output is suspicious (or outright broken?) [>=0.10.0] Argument --processed stopped producing healthy output Mar 21, 2022
@hartwork hartwork self-assigned this Mar 21, 2022
hartwork added a commit that referenced this issue Mar 21, 2022
@hartwork
Copy link
Member

There is a pull request #199 about this issue now

@hartwork hartwork added this to the 1.2.1 milestone Mar 21, 2022
hartwork added a commit that referenced this issue Mar 26, 2022
…rocessed

Fix argument --processed (fixes #197) + release 1.2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants