Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few interesting features added #35

Closed
wants to merge 6 commits into from

Conversation

franckspike
Copy link
Contributor

@franckspike franckspike commented May 16, 2019

added exclusion file
added inclusion file
added --horizontal option (vertical by default, but has no vertical explicit option…)
added json export (named jsonlt for json light, graphviz now supports exporting to json, but the current Windows version does not include it yet)

maybe you find interesting ideas in this

François

@esc
Copy link
Contributor

esc commented Dec 29, 2020

@franckspike thank you for submitting this. I think with the significant number of new features some tests will be needed before this can be merged.

@hartwork
Copy link
Member

The --horizontal switch in here seems to be what #36 is asking for.

@hartwork
Copy link
Member

hartwork commented Jan 1, 2021

I have taken the --horizontal idea a step further now to support left-to-right, right-to-left and top-to-bottom as well now in #59, keeping one of your commits. Speaking for myself, I believe that's the only part of this pull request we should adopt for the moment to keep complexity low and because we'd need to write tests ourselves for all of the other features while there has been no demand from others about these features in the last ~18 months. I hope that's okay with you for the moment. Thank you! @esc what do you think?

hartwork added a commit that referenced this pull request Jan 9, 2021
…s-other-than-upwards

Support history directions other than upwards (fixes #36, related to #35)
@esc
Copy link
Contributor

esc commented Jan 13, 2021

@hartwork that is great, thank you! @franckspike thank you very much for submitting this. We have adopted the layout direction feature as we deemed it to be interesting and it will be included in the upcoming 1.0.0 release.

@esc esc closed this Jan 13, 2021
@franckspike
Copy link
Contributor Author

@esc with pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants