Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: drop AppVoyer in favor of GitHub Action #126

Closed
khos2ow opened this issue Mar 22, 2021 · 2 comments · Fixed by #128
Closed

Proposal: drop AppVoyer in favor of GitHub Action #126

khos2ow opened this issue Mar 22, 2021 · 2 comments · Fixed by #128
Assignees
Labels
type: question Further information is requested

Comments

@khos2ow
Copy link
Collaborator

khos2ow commented Mar 22, 2021

Is there any specific reason we still use AppVoyer? More often than not continuous-integration/appveyor/branch is stalled and blocks merging of, otherwise ready, PR.

In #87 we moved CI to GitHub action and continued it in #120 with additional workflow. In reality we can remove appvoyer integration as, afaict, it only runs the tests on Windows (which can be configured to be run on GH action anyways)

/cc @mavogel @clok

@khos2ow khos2ow added the type: question Further information is requested label Mar 22, 2021
@clok
Copy link
Collaborator

clok commented Mar 22, 2021

I think this is a good call as long as we have replicated the use case in Github Actions. Looking at the configuration in the repo, I only see it running tests. https://github.com/git-chglog/git-chglog/blob/master/.appveyor.yml

We have that in our GH actions https://github.com/git-chglog/git-chglog/blob/master/.github/workflows/test.yml

@mavogel any thoughts?

@khos2ow khos2ow self-assigned this Mar 23, 2021
@mavogel
Copy link
Member

mavogel commented Mar 23, 2021

Yes, let's move away from appveyor and add a GH for it. I guess it was for testing windows specific stuff like file access etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants