Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci :updates release process #87

Merged
merged 26 commits into from Jan 16, 2021
Merged

ci :updates release process #87

merged 26 commits into from Jan 16, 2021

Conversation

mavogel
Copy link
Member

@mavogel mavogel commented Jan 9, 2021

What does this do / why do we need it?

  • the release process with gox and manual homebrew formula can be accomplished by fully automated with goreleaser
  • ci with travis is broken and PRs are red and cannot be merged. Only by project administrators
  • Github Actions are more flexible and there is also an action for goreleaser

How this PR fixes the problem?

  • Updates to goreleaser and gh-actions
  • Releases automatically to homebrew-tap
  • Removes travis and custom release scripts

What should your reviewer look out for in this PR?

{Please write here}

Check lists

  • Test passed
  • Coding style (indentation, etc)

Additional Comments (if any)

{Please write here}

Which issue(s) does this PR fix?

fixes #58

@mavogel mavogel self-assigned this Jan 9, 2021
@mavogel mavogel marked this pull request as ready for review January 12, 2021 21:33
@mavogel mavogel requested a review from khos2ow January 12, 2021 21:34
@mavogel
Copy link
Member Author

mavogel commented Jan 12, 2021

  • I tested releasing locally via curl -sL https://git.io/goreleaser | bash -s -- --skip-publish --snapshot --rm-dist and had the workflow activated for PRs as well
  • I also mailed the creator on how to fully remove travis from this repo 🤔 -> solved by adapting the branch protection strategy
  • BTW @khos2ow do have a windows machine around you'd test scoop?

@coveralls
Copy link

coveralls commented Jan 13, 2021

Pull Request Test Coverage Report for Build 488992556

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.298%

Totals Coverage Status
Change from base Build 179: 0.0%
Covered Lines: 1640
Relevant Lines: 2178

💛 - Coveralls

Copy link
Collaborator

@arsham arsham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please add an empty line at the end of the new files.

.github/workflows/release.yml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@mavogel mavogel requested a review from arsham January 14, 2021 14:12
@mavogel mavogel requested a review from arsham January 14, 2021 16:24
Copy link
Collaborator

@khos2ow khos2ow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apology for late response, this looks great @mavogel. I have couple of nits and one specific comment down below.

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@khos2ow khos2ow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mavogel for driving this, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: update release process
4 participants