Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module gopkg.in/alecaivazis/survey.v1 to github.com/AlecAivazis/survey/v2 #108

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

clok
Copy link
Collaborator

@clok clok commented Mar 4, 2021

What does this do / why do we need it?

Update gopkg.in/alecaivazis/survey to current mainline version github.com/AlecAivazis/survey/v2.

This is used within the --init command.

How this PR fixes the problem?

Updates the dependency location.

What should your reviewer look out for in this PR?

There is no change in interface from v1 to v2 with the features that we use within the module.

Check lists

  • Test passed
  • Coding style (indentation, etc)

Additional Comments (if any)

There are currently no specific tests that exercise the questioner.go code. As a result, I did compile and test locally. Everything looked solid.

Which issue(s) does this PR fix?

fixes #105

@clok clok added dependencies Pull requests that update a dependency file major labels Mar 4, 2021
@clok clok requested review from khos2ow and mavogel March 4, 2021 05:05
@clok clok self-assigned this Mar 4, 2021
@coveralls
Copy link

coveralls commented Mar 4, 2021

Pull Request Test Coverage Report for Build 622109565

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.298%

Totals Coverage Status
Change from base Build 615931147: 0.0%
Covered Lines: 1640
Relevant Lines: 2178

💛 - Coveralls

Copy link
Collaborator

@khos2ow khos2ow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @clok, seems you need to go mod tidy once more, otherwise LGTM!

@clok
Copy link
Collaborator Author

clok commented Mar 4, 2021

Thanks @clok, seems you need to go mod tidy once more, otherwise LGTM!

Nice catch on the go mod tidy @khos2ow Updates pushed.

@clok clok requested a review from khos2ow March 4, 2021 19:15
@clok clok merged commit 289163a into master Mar 4, 2021
@clok clok deleted the chore/survey-v1-to-v2 branch March 4, 2021 19:59
@evanchaoli evanchaoli mentioned this pull request Mar 8, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants