Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module gopkg.in/kyokomi/emoji.v1 to github.com/kyokomi/emoji/v2 #109

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

clok
Copy link
Collaborator

@clok clok commented Mar 4, 2021

What does this do / why do we need it?

This will update the emoji module to v2 while addressing this install error:

go: gopkg.in/kyokomi/emoji.v2@v2.2.8: parsing go.mod:
	module declares its path as: github.com/kyokomi/emoji/v2
	        but was required as: gopkg.in/kyokomi/emoji.v2

How this PR fixes the problem?

Use the desired github.com/kyokomi/emoji/v2 module declaration.

What should your reviewer look out for in this PR?

🍕 emoji 🥇

Check lists

  • Test passed
  • Coding style (indentation, etc)

Additional Comments (if any)

Just trying to get these deps cleared to start looking at the more meaty stuff.

Which issue(s) does this PR fix?

fixes #106

@clok clok added dependencies Pull requests that update a dependency file major labels Mar 4, 2021
@clok clok requested review from ghostsquad and mavogel March 4, 2021 21:31
@clok clok self-assigned this Mar 4, 2021
@coveralls
Copy link

coveralls commented Mar 4, 2021

Pull Request Test Coverage Report for Build 622693023

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.298%

Totals Coverage Status
Change from base Build 622683775: 0.0%
Covered Lines: 1640
Relevant Lines: 2178

💛 - Coveralls

@clok clok merged commit efa1c30 into master Mar 5, 2021
@clok clok deleted the chore/emoji-v1-to-v2 branch March 5, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants