Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preview string of commit subject #13

Merged
merged 1 commit into from
Mar 15, 2018

Conversation

kt3k
Copy link
Contributor

@kt3k kt3k commented Mar 15, 2018

What does this do / why do we need it?

Fixes the preview string of the commit subject.

How this PR fixes the problem?

Adds a colon.

What should your reviewer look out for in this PR?

:

Check lists

  • Test passed
  • Coding style (indentation, etc)

Additional Comments (if any)

Hi 👋

Which issue(s) does this PR fix?

None

@coveralls
Copy link

Pull Request Test Coverage Report for Build 54

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.145%

Totals Coverage Status
Change from base Build 52: 0.0%
Covered Lines: 1295
Relevant Lines: 1795

💛 - Coveralls

@wadackel wadackel self-requested a review March 15, 2018 02:12
@wadackel wadackel assigned wadackel and unassigned wadackel Mar 15, 2018
@wadackel wadackel added the type: bug Something isn't working label Mar 15, 2018
Copy link
Member

@wadackel wadackel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kt3k, Thank you for PR 😃 !!

I completely missed this mistake ...
LGTM 🎉

@wadackel wadackel merged commit e9d40da into git-chglog:master Mar 15, 2018
@wadackel
Copy link
Member

Released as 0.3.1 🙏
Thx!

@kt3k
Copy link
Contributor Author

kt3k commented Mar 15, 2018

Yay! Thanks for the quick release! 👍 👏 🙇

@kt3k kt3k deleted the feature/fix-preview branch March 15, 2018 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants