Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color output bug in windows help command #14

Merged
merged 1 commit into from
Apr 1, 2018

Conversation

wadackel
Copy link
Member

@wadackel wadackel commented Apr 1, 2018

What does this do / why do we need it?

Fix color output bug in windows help command.

How this PR fixes the problem?

  • Use mattn/go-colorable io.Writer.

What should your reviewer look out for in this PR?

  • None

Check lists

  • Test passed
  • Coding style (indentation, etc)

Additional Comments (if any)

  • None

Which issue(s) does this PR fix?

@wadackel wadackel added the type: bug Something isn't working label Apr 1, 2018
@wadackel wadackel self-assigned this Apr 1, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 59

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 72.024%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/git-chglog/main.go 0 3 0.0%
Totals Coverage Status
Change from base Build 56: -0.1%
Covered Lines: 1295
Relevant Lines: 1798

💛 - Coveralls

@wadackel wadackel merged commit 8bc61c1 into master Apr 1, 2018
@wadackel wadackel deleted the fix/windows-help-color branch April 1, 2018 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants