New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to kindly error message when git-tag does not exist #16

Merged

wadackel merged 1 commit into master from fix/empty-tag-handling

Apr 7, 2018

Member

wadackel commented Apr 7, 2018

What does this do / why do we need it?

I changed the error message when git-tag does not exist to a more comprehensible one.

How this PR fixes the problem?

None

What should your reviewer look out for in this PR?

None

Check lists

Test passed
Coding style (indentation, etc)

Additional Comments (if any)

None

Which issue(s) does this PR fix?


          feat: Change to kindly error message when git-tag does not exist

82d0df1

wadackel added the type: feature label

wadackel self-assigned this

coveralls commented Apr 7, 2018

Pull Request Test Coverage Report for Build 65

5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.005%) to 73.03%

Totals
Change from base Build 63:	1.005%
Covered Lines:	1316
Relevant Lines:	1802

💛 - Coveralls

wadackel merged commit 65eee62 into master

wadackel deleted the fix/empty-tag-handling branch

April 7, 2018 06:07

tamsky commented May 21, 2021 •

edited

Loading

This message is still causing confusion. (See #23 )

I'd suggest changing the error text
from: ERROR git-tag does not exist
to: ERROR zero git tags were found

kare commented Sep 8, 2021

Closes #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment