feat: added support for parsing headers in body, e.g. to support squashed commits #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shed commits Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Pull Request Test Coverage Report for Build 122
💛 - Coveralls |
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
wadackel
requested changes
Sep 23, 2019
| @@ -7,7 +7,7 @@ import ( | |||
| "time" | |||
|
|
|||
| "github.com/fatih/color" | |||
| chglog "github.com/git-chglog/git-chglog" | |||
| chglog "github.com/fredbi/git-chglog" | |||
There was a problem hiding this comment.
Suggested change
| chglog "github.com/fredbi/git-chglog" | |
| chglog "github.com/git-chglog/git-chglog" |
|
@tsuyoshiwada no worries we are all a bit sidetracked these days... |
gajdy
reviewed
Oct 24, 2019
| if opts.MultilineCommit { | ||
| // additional headers in body | ||
| body := input | ||
| body = p.reNotes.ReplaceAllString(body, "") // strip notes from mody |
There was a problem hiding this comment.
Suggested change
| body = p.reNotes.ReplaceAllString(body, "") // strip notes from mody | |
| body = p.reNotes.ReplaceAllString(body, "") // strip notes from body |
|
Any chances this will be merged? :) |
|
looks like there still are some outstanding PR requests. Additionally, this needs a rebase to resolve conflicts. |
|
@fredbi can we help to rebase this PR? :) |
|
Out of curiosity, was there a reason this PR didn't end up merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Frederic BIDON fredbi@yahoo.com
What does this do / why do we need it?
added support for parsing headers in body, e.g. to support squashed commits
How this PR fixes the problem?
adds
multiline_commits: true|falseconfig option to enable parsing headers in bodyWhat should your reviewer look out for in this PR?
Here is a sample regexp I am using:
Check lists
Additional Comments (if any)
{Please write here}
Which issue(s) does this PR fix?
fixes #27