-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add --tag-filter-pattern flag. #44
Conversation
Pull Request Test Coverage Report for Build 125
💛 - Coveralls |
8f420dc
to
3b70908
Compare
Can anybody please help review and merge this PR? I have added two new tests to test my change, however the coverage still dropped 0.2% because I added a CLI flag, which is 7 lines added, but |
@tsuyoshiwada Can you please review this? |
In order to fix the dropped coverage rate, I had to add |
This flag specifies a regular expression and only matched tags will be included in change log. Closes git-chglog#43
@tsuyoshiwada Can you please help review this PR? |
I would really like to see this land. I want to git-chglog it one of my projects, but only want to include certain tags into the changelog. |
IMO, I think this might be better as a configuration option in config.yml instead of as a command line option. Having both would work as well, but I think it's a fairly unchanging repository-specific configuration and would be better placed within config.yml. Here's a quick patch which converts your PR into a config.yml option (see 80b6c3b). |
@rivy I agree that it would be neat to also have it as a |
@rivy Let me explain our use case a little bit. In our project, we have several CI/CD pipelines running for per-push, daily, weekly builds, each tag the repo with different tag prefixes. So that each pipeline needs to use different tag-prefix, but they share same Actually, I have the other change, adding Jira integration. I thought to raise a PR for that change once this PR is merged, but looks like the owner of this repo is not responsive, I was thinking to clone and maintain my own fork in last week. |
@evanchaoli @rivy @alexanderwe I'm really sorry for the late response... 🙇 I agree to support only the CLI flag in this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm terribly sorry late...
Thank you for perfect work 🙏
Released as |
What does this do / why do we need it?
Our project tags the git repo in many ways. Several CI pipeline will tag with different prefixes. But we only want to include certain tags in CHANGELOG.
How this PR fixes the problem?
This PR adds a flag
--tag-filter-pattern
. This flag specifies a regular expression and only matched tags will be included in change log.What should your reviewer look out for in this PR?
Code change is tiny. No much special. The major change is in
tag_reader.go
.Check lists
Additional Comments (if any)
NA
Which issue(s) does this PR fix?
fixes #43