Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add upperFirst template function #66

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

barryib
Copy link
Contributor

@barryib barryib commented Mar 26, 2020

What does this do / why do we need it?

Add upperFirst template function. This can be useful to print subjects ({{ .Subject | upperFirst }}) in changelog.

We'll get changelog like this whatever commits message started with capital letters or not.

FEATURES:

  • Add support for additional volumes
  • Add interpreter option to wait_for_cluster_cmd

Check lists

  • Test passed
  • Coding style (indentation, etc)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 143

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 74.977%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chglog.go 0 5 0.0%
Totals Coverage Status
Change from base Build 131: -0.2%
Covered Lines: 1597
Relevant Lines: 2130

💛 - Coveralls

Copy link
Member

@wadackel wadackel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @barryib, Thank you for contributing! And I'm sorry too late...
Looks good to me!

@wadackel wadackel merged commit c1c1fe8 into git-chglog:master Apr 9, 2020
@barryib barryib deleted the add-upper-first-func branch May 7, 2020 10:42
@barryib
Copy link
Contributor Author

barryib commented May 7, 2020

@wadackel Is a new release planned shortly ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants