Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.1.0 #8

Merged
merged 6 commits into from
Feb 25, 2018
Merged

v0.1.0 #8

merged 6 commits into from
Feb 25, 2018

Conversation

wadackel
Copy link
Member

@wadackel wadackel commented Feb 25, 2018

What does this do / why do we need it?

  • Support annotated tags
  • Refactor Initializer to testable
  • And minimum bugfixes

How this PR fixes the problem?

By acquiring Tag with the following command, it changed to acquire Subject of Annotated Tag.

$ git for-each-ref --format "..." refs/tags

What should your reviewer look out for in this PR?

  • None

Check lists

  • Test passed
  • Coding style (indentation, etc)

Additional Comments (if any)

  • None

Which issue(s) does this PR fix?

Related #3

@wadackel wadackel added type: enhancement New enhancement type: feature New feature or request type: refactoring Refactoring source code or architecture labels Feb 25, 2018
@wadackel wadackel self-assigned this Feb 25, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 21

  • 250 of 400 (62.5%) changed or added relevant lines in 14 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+12.1%) to 72.393%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tag_reader.go 41 43 95.35%
cmd/git-chglog/fs_mock.go 3 5 60.0%
cmd/git-chglog/fs.go 0 7 0.0%
cmd/git-chglog/initializer.go 21 29 72.41%
cmd/git-chglog/main.go 0 30 0.0%
cmd/git-chglog/questioner.go 0 101 0.0%
Files with Coverage Reduction New Missed Lines %
cmd/git-chglog/fs_mock.go 1 80.0%
cmd/git-chglog/main.go 1 0.0%
Totals Coverage Status
Change from base Build 20: 12.1%
Covered Lines: 1180
Relevant Lines: 1630

💛 - Coveralls

@wadackel wadackel merged commit 29102c1 into master Feb 25, 2018
@wadackel wadackel deleted the feat/0.0.3 branch February 25, 2018 07:08
@wadackel wadackel changed the title v0.0.3 v0.1.0 Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New enhancement type: feature New feature or request type: refactoring Refactoring source code or architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants