Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch from dep to go mod #85

Merged
merged 4 commits into from
Jan 8, 2021
Merged

feat: switch from dep to go mod #85

merged 4 commits into from
Jan 8, 2021

Conversation

mavogel
Copy link
Member

@mavogel mavogel commented Jan 7, 2021

What does this do / why do we need it?

Switches to go modules from dep

How this PR fixes the problem?

Updates to the latest golang version and unifies the PRs

What should your reviewer look out for in this PR?

{Please write here}

Check lists

  • Test passed
  • Coding style (indentation, etc)

Additional Comments (if any)

{Please write here}

Which issue(s) does this PR fix?

This was referenced Jan 7, 2021
@mavogel mavogel requested a review from khos2ow January 7, 2021 23:35
@coveralls
Copy link

coveralls commented Jan 7, 2021

Pull Request Test Coverage Report for Build 175

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.185%

Totals Coverage Status
Change from base Build 155: 0.0%
Covered Lines: 1630
Relevant Lines: 2168

💛 - Coveralls

Copy link
Collaborator

@khos2ow khos2ow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: since vendor is removed maybe add it to .gitignore, otherwise LGTM.

@mavogel mavogel self-assigned this Jan 8, 2021
@mavogel
Copy link
Member Author

mavogel commented Jan 8, 2021

Travis passes but status is not reported back. Will address in #58

@mavogel mavogel mentioned this pull request Jan 8, 2021
@mavogel mavogel merged commit 41ad313 into master Jan 8, 2021
@mavogel mavogel deleted the feat-go-mod branch January 8, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants