Add an interactive rebase GUI with drag + drop editing

[davvid]

A gui for 'git rebase -i' would royally rock.

We'd need to check on the status on git-sequencer. Ideally we'd just be providing an interactive front end to the 'rebase -i' text file, though integrating more tightly might mean implementing parts of rebase in python.

[sylr]

I second that.

[davvid]

git 1.7.8 (not yet released) would allow us to do, for example:

$ git config --global sequencer.editor /usr/share/git-cola/bin/git-cola-rebase

...and use a custom GUI as the rebase editor. We could do all the drag/drop editing in there.

Older versions of git could accomplish the same thing by doing:

$ GIT_EDITOR=/usr/share/git-cola/bin/git-cola-rebase git rebase -i commit

So that could be one way to do it.

Newer git versions understand "fixup" and "exec" so we'll need to do some version checks so that we can suppress that option for older versions.

I'm not really sure how to best handle "reword", "edit", and "squash".

Hijacking "GIT_EDITOR" means git would execute git-cola-rebase as the editor when editing commit messages ("squash", "reword"). We obviously do not want that -- we want it to execute the regular editor e.g. gvim, or whatever git would normally use as its editor.

Do we need to make sure that core.editor is not set to something like vim which expects a terminal? We should at least warn.

It wouldn't be a bad idea to have a simple skeletor version for drag and drop re-ordering. That subset of features is safe and won't bring in the GIT_EDITOR dragons.

We could guard the advanced features behind a git-1.7.8 version check and a runtime check to ensure that GIT_EDITOR is not defined to the rebase script. We'll need to read older versions of git-rebase--interactive.sh to see what the lower bound is on the git versions to support.

In any case, I think writing a custom editor over the rebase instruction sheet is probably the way to go. What do you think @ugtar?

[ugtar]

mmmm... I think this issue is git cola's white whale =)

[davvid]

Modern Git understands GIT_SEQUENCE_EDITOR, which is what allowed us to finally spot that white 🐳 ;-)

It took a while, but it's not too shabby. It might be worth making it so that we show the message + diff when clicking a commit as a future enhancement.

[ugtar]

woohoo!

On Sun, Oct 6, 2013 at 2:33 PM, David Aguilar notifications@github.comwrote:

Modern Git understands GIT_SEQUENCE_EDITOR, which is what allowed us to
finally spot that white [image: 🐳] ;-)

It took a while, but it's not too shabby. It might be worth making it so
that we show the message + diff when clicking a commit as a future
enhancement.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1#issuecomment-25767368
.

Uri

Please consider the environment before printing this message.
http://wwf.panda.org/savepaper/