Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App version broken in macOS Monterrey #1239

Closed
darksylinc opened this issue Jun 17, 2022 · 4 comments
Closed

App version broken in macOS Monterrey #1239

darksylinc opened this issue Jun 17, 2022 · 4 comments
Labels

Comments

@darksylinc
Copy link

darksylinc commented Jun 17, 2022

What works

  1. ./git-cola.app/Contents/MacOS/git-cola from Terminal (Terminal has Full Disk Access)
  2. git-cola (from Terminal, installed by brew, Terminal has Full Disk Access)

What doesn't work

  1. open git-cola.app
  2. Double clicking git-cola.app from within Finder or Launchpad

What happens

The GUI to select which repository opens fine. But after trying to open a repository, the app will just close with no feedback (likely a crash)

Diagnostic

It appears to be a permission problem:

A

All those System Policy: ... deny ... file-read-data appear right after I double click the repository to open in git-cola and crashes /Users/matias/Documents/git-cola is the repository I'm trying to open.

Adding git-cola.app and /usr/bin/git to Full Disk Access doesn't fix it:

Untitled

@davvid davvid added the macos label Dec 24, 2022
davvid added a commit to davvid/git-cola that referenced this issue Dec 24, 2022
Avoid symlinks when creating git-cola.app so that all of the Python
dependencies are contained within the app bundle.

Related-to: git-cola#1239
Signed-off-by: David Aguilar <davvid@gmail.com>
davvid added a commit to davvid/git-cola that referenced this issue Dec 24, 2022
Attempt to grant more permissions to Git Cola by requesting them via the
Info.plist metadata.

Related-to: git-cola#1239
Signed-off-by: David Aguilar <davvid@gmail.com>
@davvid
Copy link
Member

davvid commented Dec 24, 2022

Did you build it using make git-cola.app?

I pushed in a couple of commits that may or may not help. The Makefile was updated so that git-cola.app is made to be fully insulated within the app bundle. Previously, it relied on symlinks to the python installation.

Furthermore, I updated the Info.plist file to request permissions.

The downside is that I'm unable to reproduce these errors even though I'm also on Monterrey, so I have no idea if these changes make any difference.

There's a bunch of app notarization stuff in newer versions of macOS that make some of this stuff more challenging. Hopefully we can still keep the app bundle as an option for some users, but I'll need some help figuring out what's going on.

@dxkrs
Copy link

dxkrs commented Mar 2, 2023

I install the git-cola step by step on my macos 12.6

cd ~
brew update
brew install git-cola

then I run

make git-cola.app

it show the error :

make: *** No rule to make target `git-cola'.  Stop.

Application fold haven't the app, enter the command git-cola can open the git-cola gui which only have a "Python" on the top left menu.

What wrong?

@davvid
Copy link
Member

davvid commented Mar 2, 2023

You have to be inside a clone of the git-cola repository when running make git-cola.app.

@davvid davvid closed this as completed Mar 2, 2023
@davvid
Copy link
Member

davvid commented Mar 2, 2023

For reference, this step moved you back to your $HOME directory:

cd ~

If you cloned cola to a directory called git-cola in your current directory then you would need to use cd git-cola after cloning it to enter that directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants