-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap commit messages at 72 chars #133
Conversation
It is a fairly accepted guideline that commit messages should wrap at 72 chars.
Not sure how I feel about this... I agree that 72 chars is the accepted standard, and I keep to it What if others want to have their own standards for their own To me a good way to do this, if it's desired would be to add a toggle I don't think cola should force without giving you the option to opt-out. On Sun, Jun 24, 2012 at 11:43 PM, Matthieu Rakotojaona
Uri Please consider the environment before printing this message. |
Btw, I know the Linus comment I linked to is actually arguing in favor On Mon, Jun 25, 2012 at 9:30 AM, Uri Okrent uokrent@gmail.com wrote:
Uri Please consider the environment before printing this message. |
I totally agree with you. In fact this commit is more like a Proof-of-Concept to see how it could be done. Hacking on python was so easy that I could be done with it in minutes. What I had in mind was something like this :
This will have the advantage to auto-format the commit messages for people who don't know about a very spreaded guideline. I don't think a checkbox would be a so good idea in the long run : it eats up some screen estate for a setting you will use once at the beginning of your use of git-cola, and never then. If you are curious about it, there would be the doc, as always.
And this is one of the best things I have ever seen in a GUI that has some text-editing capabilities but is not a full-blown text editor. Thank you for that ! |
Hi On Mon, Jun 25, 2012 at 10:00 AM, Matthieu Rakotojaona
Since 72 is the standard, having it be configurable might be overkill.
I agree, having it on should be the default.
I disagree with this. Having a quick way to "opt-out" right as you're Uri Please consider the environment before printing this message. |
I'll close the pull request, because it will never be merged as-is. Discussion continues in the mailing list : |
Teach the commit message editor to wrap long lines. We reuse the vim semantics, namely `cola.linebreak` and `cola.textwidth` are the configuration knobs. This feature is enabled by default but it can be toggled on a one-off basis by using the commit message editor's sprocket / settings menu. Related-to: #133 Suggested-by: Matthieu Rakotojaona <matthieu.rakotojaona@gmail.com> Helped-by: Uri Okrent <uokrent@gmail.com> Signed-off-by: David Aguilar <davvid@gmail.com>
I'll probably be merging 6263957 sometime next week. |
It is a fairly accepted guideline that commit messages should wrap at 72 chars.
Possible improvements :