New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for commit signing #149

Closed
jlec opened this Issue Nov 15, 2012 · 6 comments

Comments

Projects
None yet
3 participants
@jlec
Contributor

jlec commented Nov 15, 2012

Starting with git-1.7.9 it is possible to sign commit. Could we get support for this?

@jlec

This comment has been minimized.

Show comment
Hide comment
@jlec

jlec Nov 15, 2012

Contributor

Simple
git commit -S
does it.

Contributor

jlec commented Nov 15, 2012

Simple
git commit -S
does it.

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Nov 16, 2012

Member

Thanks, this would be helpful. I'm getting ready to release the current master. We'll start adding new features (e.g. this one) as soon as it's released.

Member

davvid commented Nov 16, 2012

Thanks, this would be helpful. I'm getting ready to release the current master. We'll start adding new features (e.g. this one) as soon as it's released.

@rosetree

This comment has been minimized.

Show comment
Hide comment
@rosetree

rosetree Sep 30, 2014

I'd love to have this feature, too. Can someone tell me the current state of this topic?

rosetree commented Sep 30, 2014

I'd love to have this feature, too. Can someone tell me the current state of this topic?

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Oct 1, 2014

Member

I can put this on the short list for v2.0.8.
v2.0.7 was just released and I try to do monthly releases.

Thanks for the reminder.

Member

davvid commented Oct 1, 2014

I can put this on the short list for v2.0.8.
v2.0.7 was just released and I try to do monthly releases.

Thanks for the reminder.

@rosetree

This comment has been minimized.

Show comment
Hide comment
@rosetree

rosetree Oct 1, 2014

That's perfect; thank you very much!

rosetree commented Oct 1, 2014

That's perfect; thank you very much!

@davvid davvid closed this in 7cb8d2a Oct 4, 2014

davvid added a commit that referenced this issue Oct 4, 2014

merge: add support for signed commits
Add a `sign` flag to the Merge command.

Add a "Create Signed Commit" checkbox to the merge dialog so
that signed commits can be toggled on/off.

Default the checkbox to:

	git config --bool cola.signcommits

This allows us to enable this feature by default by setting:

	git config cola.signcommits true

Closes #149

Suggested-by: Justin Lecher <jlec@gentoo.org>
Cheered-on-by: Micha Rosenbaum <micha@rosetree.de>
Signed-off-by: David Aguilar <davvid@gmail.com>
@rosetree

This comment has been minimized.

Show comment
Hide comment
@rosetree

rosetree Oct 5, 2014

Dear davvid, thank you for adding this feature.

rosetree commented Oct 5, 2014

Dear davvid, thank you for adding this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment