New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection not usable on currently modified directory #155

Closed
petoju opened this Issue Dec 15, 2012 · 1 comment

Comments

Projects
None yet
2 participants
@petoju

petoju commented Dec 15, 2012

Hello,

git cola selection is not usable, when there runs a program, that modifies files.
A bit extreme example

cd /tmp/
mkdir unusable-demo
cd unusable-demo
git init .
echo "important file" > ifile
echo "tmp file of editor" > bad_file
git add ifile
git commit -m "First important file"
echo "modified important1" >> ifile
echo "modified important2" >> ifile
git cola

and in another terminal

while :; do printf "" >> bad_file; done

And now try staging only "modified important2" line from ifile by selecting it in git cola. You will see, that selection is being cancelled, that is not expected behavior, as I see it.

@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Jan 7, 2013

Member

Thanks for the heads-up. This is likely because the "python-inotify" module is installed, and it will automatically refresh the GUI when it gets events from the filesystem.

We should probably do a better job of saving/restoring the user's selection.

Member

davvid commented Jan 7, 2013

Thanks for the heads-up. This is likely because the "python-inotify" module is installed, and it will automatically refresh the GUI when it gets events from the filesystem.

We should probably do a better job of saving/restoring the user's selection.

@davvid davvid closed this in 05b6c7d Jan 22, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment