Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a central notifier for keeping views in sync #19

Closed
davvid opened this issue Aug 24, 2009 · 3 comments
Closed

Add a central notifier for keeping views in sync #19

davvid opened this issue Aug 24, 2009 · 3 comments
Labels

Comments

@davvid
Copy link
Member

davvid commented Aug 24, 2009

Right now the classic and repo status views can get out of sync since they each have their own copy of the model and do not communicate with each other.

cola needs a central cola.notifier module to handle cross-object messages. Much of the tightly coupled operations (such as clicking on a file in the repo status view) could be decoupled by having the selection and other events going through the notifier.

Each view could then simply pickup messages from the notifier and react accordingly. This should allow us to, for instance, click on a filename in the classic or status views and have the diff show up in the diff view.

Full-blown updates should also go through the notifier so that refreshing one view refreshes them all.

@davvid
Copy link
Member Author

davvid commented Sep 18, 2009

We now have cola.notifier() and it's used by the new views.status widget. All we need now is a central command factory to watch for the broadcasted signals and issue appropriate cola commands.

@davvid
Copy link
Member Author

davvid commented Sep 23, 2009

This is probably about 75% done. The latest work is in 'next'.

@davvid
Copy link
Member Author

davvid commented Oct 3, 2009

cola: Integrate the SelectionModel

Selection is now handled by a static SelectionModel instance.
This allows individual tools to modify the selection and have
the selection reflected in the corresponding menus and actions.

Closed by d1f7b7c

Signed-off-by: David Aguilar davvid@gmail.com

davvid pushed a commit to davvid/git-cola that referenced this issue Jun 30, 2016
Import QIntValidator in QtGui and remove it from QtWidgets
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant