-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to push to server over ssh with public/private key #218
Comments
Hello.. I think this is similar to #262 .. do the links mentioned there help at all? This topic has come up a few times already. What OS are you on? It might be worth documenting this topic in a FAQ section so that others don't have to keep rediscovering the answer. I hope that helps. |
@systemovich Hi, please checkout the updated issue #262 if it's your issue. |
"git push" over ssh will not use SSH_ASKPASS unless we are fully detached from the terminal. It is not enough to redirect stdin and set the SSH_ASKPASS environment variable ~ we need to call os.setsid() after forking in the child process. Use subprocess.Popen's preexec_fn to call os.setsid() when executing git commands. This ensures that ssh will always use the {GIT,SSH}_ASKPASS programs, even when git-cola is launched from the terminal. The end result is that Git's password prompts will use the configured askpass program rather than prompting in the terminal. Closes git-cola#218 Closes git-cola#262 Closes git-cola#377 Reported-by: V字龍(Vdragon) <Vdragon.Taiwan@gmail.com> Reported-by: Geoffrey van Wyk <geoffrey@vanwyk.biz> Helped-by: Daniel Harding <dharding@living180.net> Helped-by: Pamela Strucker <struckerpamela@gmail.com> Helped-by: Luke Bakken <luke@bakken.io> Helped-by: Stanisław Halik <sthalik@misaki.pl> Helped-by: JiCiT <jason@infinitebubble.com> Signed-off-by: David Aguilar <davvid@gmail.com>
Please see #377 for the solution. cheers |
@davvid It is working now, thanks. |
No description provided.
The text was updated successfully, but these errors were encountered: